[webkit-reviews] review denied: [Bug 78047] [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle : [Attachment 125940] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 78047: [Qt][WK2] QQuickWebView::event should lookup faster which events
QQuickWebPage can handle
https://bugs.webkit.org/show_bug.cgi?id=78047

Attachment 125940: Patch
https://bugs.webkit.org/attachment.cgi?id=125940&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125940&action=review


Why use those raw bool arrays instead of the nice abstraction called BitVector?


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:96
> +static inline bool shouldPageHandleEvent(const QEvent::Type& event)

why const&? it's an enum, just pass by value.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1255
> +    } else if (ev->type() == QEvent::InputMethod)

Why remove the comment?