[webkit-reviews] review granted: [Bug 77914] Update LayoutUnit usage in ColumnInfo and RenderFrameSet : [Attachment 125869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 7 14:16:03 PST 2012


Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 77914: Update LayoutUnit usage in ColumnInfo and RenderFrameSet
https://bugs.webkit.org/show_bug.cgi?id=77914

Attachment 125869: Patch
https://bugs.webkit.org/attachment.cgi?id=125869&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125869&action=review


> Source/WebCore/ChangeLog:8
> +	   Updating usage of LayoutUnits in ColumnInfo and RenderFrameSet.

You should clarify in your Changelog (or code) why these are different from
table columns.

All these changes are fine, but I think you should spend a bit more effort on
the *why* explanations. :)


More information about the webkit-reviews mailing list