[webkit-reviews] review denied: [Bug 60525] Implement reverse animation direction : [Attachment 125880] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 7 14:14:28 PST 2012


Dean Jackson <dino at apple.com> has denied Igor Trindade Oliveira
<igor.oliveira at webkit.org>'s request for review:
Bug 60525: Implement reverse animation direction
https://bugs.webkit.org/show_bug.cgi?id=60525

Attachment 125880: Patch
https://bugs.webkit.org/attachment.cgi?id=125880&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125880&action=review


I think we need a test for "reverse" as well. I could only see one for
"alternate-reverse". r- for the missing test, but otherwise looks good.

NOTE: Apple will need to raise a followup bug because our hardware animation
won't support this directly.

> LayoutTests/animations/animation-direction-alternate-reverse.html:53
> +<!-- Test animation-direction: alternate -->

Nit: it's now alternate-reverse


More information about the webkit-reviews mailing list