[webkit-reviews] review denied: [Bug 76571] Add fixed point types for sub-pixel layout : [Attachment 124846] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 76571: Add fixed point types for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=76571

Attachment 124846: Patch
https://bugs.webkit.org/attachment.cgi?id=124846&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124846&action=review


It also starts to feel to me like we may need a PointBase/RectBase/SizeBase
classes (not necssarily in this patch, but at some point in the future) to
share code between our now 3 types.

> Source/WebCore/platform/graphics/FixedPoint.h:53
> +#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
> +typedef struct CGPoint CGPoint;
> +#endif
> +
> +
> +#if OS(DARWIN) && !PLATFORM(QT)
> +#ifdef NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
> +typedef struct CGPoint NSPoint;
> +#else
> +typedef struct _NSPoint NSPoint;
> +#endif
> +#endif

As discussed in person, seems we should drop the ability to convert directly to
native types from Fixed*.  That makes it explicit in teh few places we want to
convert (and should substantially reduce the code in this patch).