[webkit-reviews] review granted: [Bug 78013] [chromium] Gracefully handle compositor initialization failure in single-threaded proxy : [Attachment 125908] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 78013: [chromium] Gracefully handle compositor initialization failure in
single-threaded proxy
https://bugs.webkit.org/show_bug.cgi?id=78013

Attachment 125908: Patch
https://bugs.webkit.org/attachment.cgi?id=125908&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125908&action=review


Looks OK assuming it's been tested; one comment.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:187
> +    bool updateLayers();

Please document the semantics of the return value. Why do some of the early
outs in updateLayers return true?