[webkit-reviews] review granted: [Bug 77912] [CG] Remove old CG specific shadow setting code from canvas : [Attachment 125868] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (on vacation until 2-14) <simon.fraser at apple.com> has granted
Matthew Delaney <mdelaney at apple.com>'s request for review:
Bug 77912: [CG] Remove old CG specific shadow setting code from canvas
https://bugs.webkit.org/show_bug.cgi?id=77912

Attachment 125868: Patch
https://bugs.webkit.org/attachment.cgi?id=125868&action=review

------- Additional Comments from Simon Fraser (on vacation until 2-14)
<simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125868&action=review


> Source/WebCore/ChangeLog:8
> +	   The CG specific shadow offset hack was added in
http://trac.webkit.org/changeset/34317
> +	   but has since moved down into GraphicsContextCG::setLegacyShadow
that is called
> +	   by applyShadow() thus the shadow hack is redundant here if we call
applyShadow()

It's very hard to parse this run-on sentence.

> Source/WebCore/ChangeLog:12
> +	   The CG specific shadow setting block of code is redundant since any
setting we
> +	   do here to the CGContext will get overwritten later by any
subsequent shadow setting
> +	   or unsetting since the values in the State object are what's push
down into CG.

And this one.