[webkit-reviews] review denied: [Bug 77993] [BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes : [Attachment 125857] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Jacky Jiang <zkjiang008 at gmail.com>'s
request for review:
Bug 77993: [BlackBerry] Upstream BlackBerry WebCoreSupport
DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77993

Attachment 125857: Patch
https://bugs.webkit.org/attachment.cgi?id=125857&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125857&action=review


I think this can be cleaned up a bit more.

> Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp:24
> +#include "Page.h"

You don't need this include.

> Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h:25
> +#include <BlackBerryPlatformDeviceMotionTracker.h>

You don't need this include, a forward class reference is enough.

>
Source/WebKit/blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:2
3
> +#include "Page.h"

You don't need this include.

>
Source/WebKit/blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h:25
> +#include <BlackBerryPlatformDeviceOrientationTracker.h>

You don't need to include this, a forward reference should be ok.