[webkit-reviews] review granted: [Bug 77924] Dashboard on perf-o-matic should be sorted : [Attachment 125750] Fixes the bug

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 77924: Dashboard on perf-o-matic should be sorted
https://bugs.webkit.org/show_bug.cgi?id=77924

Attachment 125750: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=125750&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125750&action=review


> Websites/webkit-perf.appspot.com/js/config.js:84
> +	   for (test in testToId)
> +	       tests.push(test);

Can you use Object.keys(testToId)?

> Websites/webkit-perf.appspot.com/js/config.js:88
> +	   for (var i = 0; i < tests.length; i++)
> +	       sortedTestToId[tests[i]] = testToId[tests[i]];
> +	   dashboardManifest['testToId'] = sortedTestToId;

This is OK, but it would be more efficient to sort when you use
dashboardManifest['testToId'].	I guess that involves changing perfomatic code.