[webkit-reviews] review granted: [Bug 77885] Use CMClock as a timing source for PlatformClock where available. : [Attachment 125672] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 77885: Use CMClock as a timing source for PlatformClock where available.
https://bugs.webkit.org/show_bug.cgi?id=77885

Attachment 125672: Patch
https://bugs.webkit.org/attachment.cgi?id=125672&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125672&action=review


> Source/WebCore/platform/mac/PlatformClockCM.mm:48
> +static const int32_t DefaultTimeScale = 1000;

Please include a comment explaining why 1000 is the best magic timescale.

> Source/WebCore/platform/mac/PlatformClockCM.mm:57
> +    CMAudioDeviceClockCreate(kCFAllocatorDefault, NULL, &rawClockPtr);
> +    RetainPtr<CMClockRef> clock(AdoptCF, rawClockPtr);
> +    initializeWithTimingSource(clock.get());

Is the temporary RetainPtr necessary?