[webkit-reviews] review granted: [Bug 77843] [BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp} : [Attachment 125767] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 7 06:39:13 PST 2012
Antonio Gomes <tonikitoo at webkit.org> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 77843: [BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843
Attachment 125767: Patch v2
https://bugs.webkit.org/attachment.cgi?id=125767&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125767&action=review
> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:476
> +#if ENABLE(EVENT_MODE_METATAGS)
> +void ChromeClientBlackBerry::didReceiveCursorEventMode(Frame* frame,
CursorEventMode mode) const
> +{
> + if (m_webPagePrivate->m_mainFrame != frame)
> + return;
> +
> + m_webPagePrivate->didReceiveCursorEventMode(mode);
> +}
> +
> +void ChromeClientBlackBerry::didReceiveTouchEventMode(Frame* frame,
TouchEventMode mode) const
> +{
> + if (m_webPagePrivate->m_mainFrame != frame)
> + return;
> +
> + m_webPagePrivate->didReceiveTouchEventMode(mode);
> +}
> +#endif
the WebCore counter part of these methods are intended to be upstreamed?
> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:604
> +void ChromeClientBlackBerry::invalidateContentsForSlowScroll(const IntSize&
delta, const IntRect& updateRect, bool immediate, const ScrollView* scrollView)
it also requires changes in scrollview I am not sure we will upstream.
> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.h:2
> + * Copyright (C) 2009, 2010, 2011 Research In Motion Limited. All rights
reserved.
2012?
More information about the webkit-reviews
mailing list