[webkit-reviews] review denied: [Bug 77865] Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness : [Attachment 125665] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 77865: Web Inspector: Closed computed style sidebar pane rebuilds,
resulting in slowness
https://bugs.webkit.org/show_bug.cgi?id=77865

Attachment 125665: Patch
https://bugs.webkit.org/attachment.cgi?id=125665&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125665&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:860
> +	       WebInspector.SidebarPane.prototype.expand.call(this,
userCallback);

You could sniff this in a test.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:866
> +	      
WebInspector.panels.elements.sidebarPanes.styles._refreshComputedStyleSection(c
allback.bind(this, userCallback));

I would leave this as the only path for the sake of the code simplicity.