[webkit-reviews] review granted: [Bug 63608] [EFL][WK2] Add ModuleEfl.cpp : [Attachment 122401] patch for ModuleEfl
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 7 03:03:49 PST 2012
Andreas Kling <kling at webkit.org> has granted YoungTaeck Song
<youngtaeck.song at samsung.com>'s request for review:
Bug 63608: [EFL][WK2] Add ModuleEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=63608
Attachment 122401: patch for ModuleEfl
https://bugs.webkit.org/attachment.cgi?id=122401&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122401&action=review
r=me, with two suggestions:
> Source/WebKit2/Platform/efl/ModuleEfl.cpp:32
> + if (!m_module.get() || !eina_module_load(m_module.get())) {
You don't need the .get() when null-checking an OwnPtr as it overrides
operator!, this will work just as well:
if (!m_module || !eina_module_load(m_module.get())) {
> Source/WebKit2/Platform/efl/ModuleEfl.cpp:47
> + if (m_module.get())
Same here:
if (m_module)
More information about the webkit-reviews
mailing list