[webkit-reviews] review granted: [Bug 77736] Rewrite SVG tests to make extensive use of display() in repaint tests : [Attachment 125601] Patch v7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 7 02:42:07 PST 2012


Andreas Kling <kling at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 77736: Rewrite SVG tests to make extensive use of display() in repaint
tests
https://bugs.webkit.org/show_bug.cgi?id=77736

Attachment 125601: Patch v7
https://bugs.webkit.org/attachment.cgi?id=125601&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125601&action=review


Looks pretty damn good. r=me!

> LayoutTests/ChangeLog:8
> +	   Convert all tests in svg/ (except svg/custom & svg/dynamic-updates)
that excersive repainting to use the

Typo, exercise.

> LayoutTests/svg/as-background-image/animated-svg-as-background.html:9
> +    // The animation durates 100ms. Wait 200ms for the repaint.

Not sure 'durate' is an English word. Same comment for all occurrences. :)


More information about the webkit-reviews mailing list