[webkit-reviews] review denied: [Bug 77926] [Blackberry] Clean up Networkjob and Networkmanger: remove unused variables and change some public functions into be private ones : [Attachment 125762] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 21:37:50 PST 2012


Antonio Gomes <tonikitoo at webkit.org> has denied Chris.Guan
<chris.guan at torchmobile.com.cn>'s request for review:
Bug 77926: [Blackberry] Clean up Networkjob and Networkmanger: remove unused
variables and change some public functions into be private ones
https://bugs.webkit.org/show_bug.cgi?id=77926

Attachment 125762: Patch
https://bugs.webkit.org/attachment.cgi?id=125762&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125762&action=review


please, lets find a better name than clientIsOk, since we are around :)

> Source/WebCore/ChangeLog:9
> +	   2. Remove an ASSERT in NetworkManger, becuase never hit it.

because* it is never hit


More information about the webkit-reviews mailing list