[webkit-reviews] review denied: [Bug 61338] Element not fully repainted after application and removal of transform : [Attachment 125619] Fix to repaint the element when its transform property changes

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has denied KishoreGanesh
<kbolisetty at innominds.com>'s request for review:
Bug 61338: Element not fully repainted after application and removal of
transform
https://bugs.webkit.org/show_bug.cgi?id=61338

Attachment 125619: Fix to repaint the element when its transform property
changes
https://bugs.webkit.org/attachment.cgi?id=125619&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125619&action=review


Your patch is confusing our review tool (we can't see the png baseline) and
webkit-patch (all the EWS cannot apply the patch). Make sure you use
webkit-patch upload for your next patch.

> LayoutTests/fast/repaint/transform-rotate-remove.html:29
> +	   <div id='try' style="border:1px solid red; background-color:pink;
height: 50px; width:200px;" onclick="rotate();">TRY IT OUT!</div>

Avoid to use text as this makes the test platform dependant. See
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree#Pix
eltesttips