[webkit-reviews] review granted: [Bug 76388] [GTK] Make distcheck is broken when using make -j : [Attachment 125730] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 16:53:29 PST 2012


Martin Robinson <mrobinson at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 76388: [GTK] Make distcheck is broken when using make -j
https://bugs.webkit.org/show_bug.cgi?id=76388

Attachment 125730: Patch
https://bugs.webkit.org/attachment.cgi?id=125730&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125730&action=review


This fix looks sane, but do you mind making the small change below before
landing?

> Source/WebCore/GNUmakefile.am:812
> +	$(webkitgtk_gdom_built_sources)

The GDOM sources are actually part of the WebKit build, not the WebCore one. It
might make more sense to add it to BUILT_SOURCES in
Source/WebCore/bindings/gobject/GNUmakefile.am.


More information about the webkit-reviews mailing list