[webkit-reviews] review granted: [Bug 77908] http/tests/security/xssAuditor/cookie-injection.html is flaky : [Attachment 125717] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 77908: http/tests/security/xssAuditor/cookie-injection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77908

Attachment 125717: Patch
https://bugs.webkit.org/attachment.cgi?id=125717&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125717&action=review


The change looks fine now that I understand it.

> LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl:51
> +    print "<script>if (/testcookie/.exec(document.cookie)) { alert('FAIL: '
+ document.cookie); document.cookie = 'testcookie=remove; max-age=-1';
}</script>\n";

I think you want .test() instead of .exec():
https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/RegExp/tes
t

> LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl:52
>  }

I think we should also alert PASS to make it clearer that it passed.