[webkit-reviews] review granted: [Bug 76931] RenderSVGShape::strokeContains will fail for some strokes : [Attachment 125705] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Stephen Chenney
<schenney at chromium.org>'s request for review:
Bug 76931: RenderSVGShape::strokeContains will fail for some strokes
https://bugs.webkit.org/show_bug.cgi?id=76931

Attachment 125705: Patch
https://bugs.webkit.org/attachment.cgi?id=125705&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125705&action=review


> LayoutTests/svg/hittest/zero-length-butt-cap-path-expected.txt:1
> +PASSED; PASSED; PASSED; PASSED; PASSED; PASSED; PASSED; PASSED;

Test output is a little cryptic. Tests that make it clear in the output what
they are testing are even better.

> LayoutTests/svg/hittest/zero-length-butt-cap-path-expected.txt:6
>  Added: svn:eol-style
>    + LF

We normally use eol-style native instead of LF. Not sure why you’re doing it
differently on these files.