[webkit-reviews] review granted: [Bug 77387] Avoid Page::updateViewportArguments() if the causing frame is not the main frame : [Attachment 125366] patch v2 (moved updateViewportArguments from Page to Document)

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 77387: Avoid Page::updateViewportArguments() if the causing frame is not
the main frame
https://bugs.webkit.org/show_bug.cgi?id=77387

Attachment 125366: patch v2 (moved updateViewportArguments from Page to
Document)
https://bugs.webkit.org/attachment.cgi?id=125366&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125366&action=review


>>> Source/WebCore/html/HTMLBodyElement.cpp:186
>>> +	 document()->updateViewportArguments();
>> 
>> missing if (document())
> 
> document() won't be NULL, because here is insertedIntoDocument(). Also there
are at least 2 "document()->" in the function.

You could add an ASSERT just in case