[webkit-reviews] review denied: [Bug 76762] js-test-pre.js: relay calls to testPassed, testFailed, debug, etc from worker to document : [Attachment 125701] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied David Grogan <dgrogan at chromium.org>'s
request for review:
Bug 76762: js-test-pre.js: relay calls to testPassed, testFailed, debug, etc
from worker to document
https://bugs.webkit.org/show_bug.cgi?id=76762

Attachment 125701: Patch
https://bugs.webkit.org/attachment.cgi?id=125701&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125701&action=review


Looks fine to me, I would just like to see the requirement of prefixing with
CODE: to go away. Makes writing more generic worker tests easier.

> LayoutTests/fast/js/resources/js-test-pre.js:459
> +	       debug("Got invalid message from worker:" + (event.data ?
event.data : "null"));

Printing null for the empty string seems wrong to me. We should print "''" or
just leave it as the empty string.

Instead of requiring the arbitrary messages be prefixed with MESG:, how about
making anything that doesn't start with CODE: get printed to debug.