[webkit-reviews] review granted: [Bug 77881] [filesystem/Chromium] crackFileSystemURL needs to use innerURL : [Attachment 125675] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 13:10:50 PST 2012


Adam Barth <abarth at webkit.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 77881: [filesystem/Chromium] crackFileSystemURL needs to use innerURL
https://bugs.webkit.org/show_bug.cgi?id=77881

Attachment 125675: Patch
https://bugs.webkit.org/attachment.cgi?id=125675&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125675&action=review


> Source/WebKit/chromium/src/AsyncFileSystemChromium.cpp:67
> +	   String typeString = url.innerURL()->path().substring(1);

There's probably a way to do this that saves some mallocs.  If this is
performance-sensitive code, we might want to investigate further.


More information about the webkit-reviews mailing list