[webkit-reviews] review granted: [Bug 77800] Provide more attribute methods in Element : [Attachment 125630] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 77800: Provide more attribute methods in Element
https://bugs.webkit.org/show_bug.cgi?id=77800

Attachment 125630: Patch
https://bugs.webkit.org/attachment.cgi?id=125630&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125630&action=review


> Source/WebCore/dom/Element.h:135
> +    // This variant will not update the potentially invalid attributes. To
be used when not interested
> +    // in style attribute or one of the SVG animation attributes.
> +    bool hasAttributesWithoutUpdate() const;

Instead of adding comments, should we rename the function to
hasAttributesWithoutUpdatingStyleAndSVGAnimations()?

> Source/WebCore/dom/Element.h:160
> +    // Internal methods that assume the existence of attribute storage, one
should use hasAttributes()
> +    // before calling them.
> +    size_t attributeCount() const;
> +    Attribute* attributeItem(unsigned index) const;
> +    Attribute* getAttributeItem(const QualifiedName&) const;
> +    void removeAttribute(unsigned index);

Can we eventually make them private/protected?

> Source/WebCore/xml/XPathNodeSet.cpp:216
> +	   Element* e = toElement(n);

Please spell-out element.