[webkit-reviews] review requested: [Bug 76275] [Qt] [WK2] WebView should use Flickable instead of QScroller to handle positioning : [Attachment 125663] proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 09:28:14 PST 2012


Andras Becsi <abecsi at webkit.org> has asked  for review:
Bug 76275: [Qt] [WK2] WebView should use Flickable instead of QScroller to
handle positioning
https://bugs.webkit.org/show_bug.cgi?id=76275

Attachment 125663: proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=125663&action=review

------- Additional Comments from Andras Becsi <abecsi at webkit.org>
Refactored the previous patch and moved the glue code into its separate class
not to pollute the qquickwebview.cpp.
This depends on the componentComplete patch and most probably won't apply
without it to trunk.

Kenneth, Simon could you take another look?
Compared to the r+-ed patch - apart from the separation of the QtFlickProvider
- in this patch all the methods and properties are resolved.


More information about the webkit-reviews mailing list