[webkit-reviews] review denied: [Bug 77865] Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness : [Attachment 125657] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 77865: Web Inspector: Closed computed style sidebar pane rebuilds,
resulting in slowness
https://bugs.webkit.org/show_bug.cgi?id=77865

Attachment 125657: Patch
https://bugs.webkit.org/attachment.cgi?id=125657&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125657&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:864
> +	   if
(WebInspector.panels.elements.sidebarPanes.styles.sections[0][0].propertiesElem
ent.children.length)

You should never access styles via the panel.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:870
> +    _expandedForTest: function(node)

You could sniff instead.

> LayoutTests/inspector/elements/elements-panel-styles.html:11
> +    InspectorTest.selectNodeAndWaitForStylesWithComputed("foo", step1);

It would be great to have a test that checks that computed style is not loaded
initially, but is loaded on demand.