[webkit-reviews] review denied: [Bug 77865] Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness : [Attachment 125633] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 77865: Web Inspector: Closed computed style sidebar pane rebuilds,
resulting in slowness
https://bugs.webkit.org/show_bug.cgi?id=77865

Attachment 125633: Patch
https://bugs.webkit.org/attachment.cgi?id=125633&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125633&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:258
> +	       resultStyles.computedStyle = new
WebInspector.CSSStyleDeclaration({ cssProperties: [], shorthandEntries: {} });

Why not null?

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-493
> -    _markUsedProperties: function(styleRules, usedProperties,
disabledComputedProperties)

I'd suggest that you remove disabledComputedProperties as a separate change.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:854
> +    // Overriding expand() rather than onexpand() to eliminate visual
slowness due to a possible backend trip.

Why exactly is this needed?

> LayoutTests/http/tests/inspector/elements-test.js:86
> +InspectorTest.selectNodeAndWaitForStyles = function(idValue,
expandComputedStyles, callback)

Not the best change to the harness given that all the clients now need to think
about the computed style. I'd suggest that you introduce a separate command
that expands it separately.

> LayoutTests/http/tests/inspector/elements-test.js:107
> +	       InspectorTest.runAfterPendingDispatches(function() {

We should not use runAfterPendingDispatches if at all possible.