[webkit-reviews] review denied: [Bug 77096] Web Inspector: [Meta] Allow emulation of touch events : [Attachment 125639] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 77096: Web Inspector: [Meta] Allow emulation of touch events
https://bugs.webkit.org/show_bug.cgi?id=77096

Attachment 125639: Patch
https://bugs.webkit.org/attachment.cgi?id=125639&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125639&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:222
> +    m_state->setBoolean(DOMAgentState::touchEventEmulationEnabled, false);

You should hide this.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1068
> +    if (m_state->getBoolean(DOMAgentState::touchEventEmulationEnabled) ==
enabled)

You could put this above the ENABLE as an entry guard.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1072
> +    *error = "Touch event emulation not enabled";

Touch events emulation not supported.

> Source/WebCore/inspector/front-end/SettingsScreen.js:43
> +    if (Preferences.showDockToRight && Preferences.exposeDisableCache) {

&& -> ||

> Source/WebCore/page/EventHandler.cpp:1783
> +#if ENABLE(TOUCH_EVENTS)

Should be in a separate change.