[webkit-reviews] review granted: [Bug 75308] [GTK] Add TextureMapperGL implementation : [Attachment 125591] Properly handle little endian systems with OpenGL ES

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 75308: [GTK] Add TextureMapperGL implementation
https://bugs.webkit.org/show_bug.cgi?id=75308

Attachment 125591: Properly handle little endian systems with OpenGL ES
https://bugs.webkit.org/attachment.cgi?id=125591&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
LGTM, works great :). I just had to add this code to make it compile. Noam are
this ifdefs in DrawingAreaProxyImpl.cpp correct? I did not check much that
code.

diff --git a/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
b/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
index 4c3447b..ba886a0 100644
--- a/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
+++ b/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
@@ -1139,6 +1139,24 @@ InterpolationQuality
GraphicsContext::imageInterpolationQuality() const
     return platformContext()->imageInterpolationQuality();
 }
 
+#if ENABLE(3D_RENDERING) && USE(TEXTURE_MAPPER)
+TransformationMatrix GraphicsContext::get3DTransform() const
+{
+    notImplemented();
+    return TransformationMatrix();
+}
+
+void GraphicsContext::concat3DTransform(const TransformationMatrix& transform)

+{
+    notImplemented();
+}
+
+void GraphicsContext::set3DTransform(const TransformationMatrix& transform)
+{
+    notImplemented();
+}
+#endif
+
 } // namespace WebCore
 
 #endif // USE(CAIRO)
diff --git a/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
b/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
index 24a5aed..ffc60cf 100644
--- a/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
+++ b/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
@@ -36,7 +36,7 @@
 #include "WebProcessProxy.h"
 #include <WebCore/Region.h>
 
-#if USE(ACCELERATED_COMPOSITING) && USE(TEXTURE_MAPPER)
+#if USE(ACCELERATED_COMPOSITING) && USE(TEXTURE_MAPPER) &&
USE(TILED_BACKING_STORE)
 #include "LayerTreeHostProxy.h"
 #endif
 
@@ -58,7 +58,7 @@ DrawingAreaProxyImpl::DrawingAreaProxyImpl(WebPageProxy*
webPageProxy)
     , m_isBackingStoreDiscardable(true)
     , m_discardBackingStoreTimer(RunLoop::current(), this,
&DrawingAreaProxyImpl::discardBackingStore)
 {
-#if USE(TEXTURE_MAPPER)
+#if USE(TEXTURE_MAPPER) && USE(TILED_BACKING_STORE)
     // Construct the proxy early to allow messages to be sent to the web
process while AC is entered there.
     if (webPageProxy->pageGroup()->preferences()->forceCompositingMode())
	 m_layerTreeHostProxy = adoptPtr(new LayerTreeHostProxy(this));
@@ -335,7 +335,7 @@ void
DrawingAreaProxyImpl::enterAcceleratedCompositingMode(const LayerTreeContex
     m_backingStore = nullptr;
     m_layerTreeContext = layerTreeContext;
     m_webPageProxy->enterAcceleratedCompositingMode(layerTreeContext);
-#if USE(TEXTURE_MAPPER)
+#if USE(TEXTURE_MAPPER) && USE(TILED_BACKING_STORE)
     if (!m_layerTreeHostProxy)
	 m_layerTreeHostProxy = adoptPtr(new LayerTreeHostProxy(this));
 #endif