[webkit-reviews] review granted: [Bug 77732] Speech input: fix fast/speech/bubble-position.html : [Attachment 125604] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 6 04:14:47 PST 2012
Tony Gentilcore <tonyg at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 77732: Speech input: fix fast/speech/bubble-position.html
https://bugs.webkit.org/show_bug.cgi?id=77732
Attachment 125604: Patch
https://bugs.webkit.org/attachment.cgi?id=125604&action=review
------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125604&action=review
> LayoutTests/fast/speech/bubble-position.html:19
> + debug("rect is inside the iframe");
Better to use testPassed/testFailed instead of debug.
testPassed("rect is inside the iframe");
> LayoutTests/fast/speech/bubble-position.html:23
> + debug("rect.y: " + y);
testFailed("rect was outside the iframe. Actual rect.x: " + x + ", rect.y: " +
y);
More information about the webkit-reviews
mailing list