[webkit-reviews] review denied: [Bug 77850] Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree. : [Attachment 125572] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 77850: Web Inspector: get rid of artificial heap snapshot nodes from the
retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=77850

Attachment 125572: Patch
https://bugs.webkit.org/attachment.cgi?id=125572&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125572&action=review


> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:399
> +	       "	&& (" + !this.showRetainingEdges + " || (!edge.node.id
!== 1 && !edge.node.isArtificial))\n" +

!edge.node.id !== 1 will always evaluate to true, r- for this.