[webkit-reviews] review denied: [Bug 76995] WebKit fails IETC :indeterminate and input type=radio test : [Attachment 125559] Patch-BasedOn-ReviewComments

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 76995: WebKit fails IETC :indeterminate and input type=radio test
https://bugs.webkit.org/show_bug.cgi?id=76995

Attachment 125559: Patch-BasedOn-ReviewComments
https://bugs.webkit.org/attachment.cgi?id=125559&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125559&action=review


> Source/WebCore/html/HTMLInputElement.cpp:950
>  {
> -    if (!m_inputType->isCheckable() || indeterminate() == newValue)
> +    if (indeterminate() == newValue)
>	   return;

We need a test for this new behavior.

> Source/WebCore/html/RadioInputType.cpp:157
>      state->checked = element()->checked();
> -    state->indeterminate = element()->indeterminate();
>      state->checkedRadioButton =
element()->checkedRadioButtons().checkedButtonForGroup(element()->name());
>  
> -    if (element()->indeterminate())
> -	   element()->setIndeterminate(false);
>      element()->setChecked(true, true);

Need to enclose PLATFORM(IOS)?

> Source/WebCore/html/RadioInputType.cpp:174
>	   }
> -	   element()->setIndeterminate(state.indeterminate);
>      }

ditto.

> Source/WebCore/html/RadioInputType.cpp:191
> +#if PLATFORM(IOS)
> +    return true;
> +#endif
> +
> +    return false;

There are two returns if PLATFORM(IOS).