[webkit-reviews] review denied: [Bug 76366] [Blackberry] Non-supported about: operations never stops loading : [Attachment 125556] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 5 20:33:03 PST 2012
Antonio Gomes <tonikitoo at webkit.org> has denied Chris.Guan
<chris.guan at torchmobile.com.cn>'s request for review:
Bug 76366: [Blackberry] Non-supported about: operations never stops loading
https://bugs.webkit.org/show_bug.cgi?id=76366
Attachment 125556: Patch
https://bugs.webkit.org/attachment.cgi?id=125556&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125556&action=review
you amended wrongly :-)
> Source/WebCore/ChangeLog:8
> + If user typed the non-supported "about:" scheme such as
"about:nonsupport",
nit: s/the/a
> Source/WebCore/ChangeLog:9
> + loadAboutURL() fucntion in NetworkManger should recognize and handle
typo: function*
> Source/WebCore/ChangeLog:33
> +2012-02-05 Andreas Kling <awesomekling at apple.com>
> +
> + Remove unused file MappedAttributeEntry.h.
> + <http://webkit.org/b/77841>
> +
> + Reviewed by Anders Carlsson.
> +
> + * GNUmakefile.list.am:
> + * WebCore.gypi:
> + * WebCore.vcproj/WebCore.vcproj:
> + * WebCore.xcodeproj/project.pbxproj:
> + * dom/MappedAttributeEntry.h: Removed.
> + * dom/StyledElement.h:
> +
this should not be here :-)
More information about the webkit-reviews
mailing list