[webkit-reviews] review denied: [Bug 77843] [BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp} : [Attachment 125552] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 5 19:59:54 PST 2012


Antonio Gomes <tonikitoo at webkit.org> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 77843: [BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843

Attachment 125552: Patch
https://bugs.webkit.org/attachment.cgi?id=125552&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125552&action=review


the change I will request is easy but should be addressed internally first, and
then we generate this patch again for upstreaming. r- due to that.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:82
> +ChromeClientBlackBerry::ChromeClientBlackBerry(WebPage* page)
> +    : m_webPage(page)

should awebpageprivate, not the public class


More information about the webkit-reviews mailing list