[webkit-reviews] review denied: [Bug 75478] <summary> is not keyboard accessible : [Attachment 125322] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 5 16:39:28 PST 2012


MORITA Hajime <morrita at google.com> has denied Arko Saha <nghq36 at motorola.com>'s
request for review:
Bug 75478: <summary> is not keyboard accessible
https://bugs.webkit.org/show_bug.cgi?id=75478

Attachment 125322: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=125322&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
Hi Arko, Thanks for taking this!

Here is my thought:
- Without focus, it's not so easy to send a key events to the specific element.

   So it would be great if we can make <summary> focusable.
   There are some elements which support gaining focus and it would be good
starting point to follow their way.
   I guess we can handle DOMActivate event.
- On testing, please use EventSender instead of dispatchEvent(). Each of these
two goes different code path, 
   and EventSender is suited for emulating user behavior.


More information about the webkit-reviews mailing list