[webkit-reviews] review denied: [Bug 77425] [CMAKE] Support javascriptcore test for EFL port : [Attachment 124930] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 77425: [CMAKE] Support javascriptcore test for EFL port
https://bugs.webkit.org/show_bug.cgi?id=77425

Attachment 124930: Patch
https://bugs.webkit.org/attachment.cgi?id=124930&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124930&action=review


The patch seems to be fixing two bugs. While both the EFL JavaScript shell
properties/name changes and ENABLE_TOOLS changes look reasonable these changes
seem mutually exclusive and hence should be separated into individual bugs.

> ChangeLog:11
> +	   Do not build Tools when jsc is only built. Build breaks occur
because
> +	   Tools is built together when building jsc. In addition, change
*jsc_efl*
> +	   executable name with *jsc* in order to run run-javascriptcore-tests.

> +

The EFL JavaScript shell build is currently broken? Regardless, the first and
second sentence in this ChangeLog and the ENABLE_TOOLS changes made to
CMakeLists.txt seem unrelated to the issue mentioned in the description of this
bug (comment #0). I suggest extracting the Tools changes into a separate bug.