[webkit-reviews] review granted: [Bug 77204] Kill per-Attribute style declarations. : [Attachment 125445] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 77204: Kill per-Attribute style declarations.
https://bugs.webkit.org/show_bug.cgi?id=77204

Attachment 125445: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=125445&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=125445&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:1006
> +		   result.isCacheable = false;

Caching is useful even when properties are not shared between elements as it is
common for the same element style to get recomputed.

We should be able to share identical attribute styles between elements too.

> Source/WebCore/dom/Attr.h:62
> +    // A deprecated extension to get presentational information for
attributes.
> +    // We have to keep it around because it's exposed in the Obj-C DOM API.
> +    CSSStyleDeclaration* style() { return 0; }

Hope we don't have clients for this!

> Source/WebCore/dom/CSSMappedAttributeDeclaration.h:-76
>  
>      RefPtr<StylePropertySet> m_declaration;
> -    MappedAttributeEntry m_entryType;
> -    QualifiedName m_attrName;
> -    AtomicString m_attrValue;

This class has kinda lost its reason to exist.