[webkit-reviews] review granted: [Bug 77801] Web Inspector: get reed of cycles in retaining tree : [Attachment 125473] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 77801: Web Inspector: get reed of cycles in retaining tree
https://bugs.webkit.org/show_bug.cgi?id=77801

Attachment 125473: Patch
https://bugs.webkit.org/attachment.cgi?id=125473&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125473&action=review


> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:380
> +	       while (ancestor) {

We may stop if the parentGridNode already has _cycledWithAncestorGridNode set.

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:388
> +	  
WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren.call(th
is);

Please remvoe leading underscore from _updateHasChildren  method name since you
override it, by the convention only private methods should start with _.

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:-444
> -	       prefixSpan.textContent = WebInspector.UIString("retained by ");

Please mention this UI change in the changelog.

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:458
> +	   if (this._cycledWithAncestorGridNode) {

We need some UI for navigating to the first occurrence of the node in the
ancesors chain but this can be done in a separate patch.