[webkit-reviews] review granted: [Bug 77795] WebKit2 should dispatch wheel events to the new ScrollingTree class : [Attachment 125456] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 17:53:11 PST 2012


Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 77795: WebKit2 should dispatch wheel events to the new ScrollingTree class
https://bugs.webkit.org/show_bug.cgi?id=77795

Attachment 125456: Patch
https://bugs.webkit.org/attachment.cgi?id=125456&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125456&action=review


Ok.

> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:88
> +	   

Whitespace.

> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:-111
> -#if ENABLE(THREADED_SCROLLING)
> -    MutexLocker locker(m_scrollingCoordinatorsMutex);
> -    if (ScrollingCoordinator* scrollingCoordinator =
m_scrollingCoordinators.get(pageID).get()) {
> -	   PlatformGestureEvent platformGestureEvent = platform(gestureEvent);
> -
> -	   if (scrollingCoordinator->handleGestureEvent(platformGestureEvent))
{
> -	       sendDidHandleEvent(pageID, gestureEvent);
> -	       return;
> -	   }
> -    }
> -#endif

ChangeLog is missing a blurb about the removal of this hunk.


More information about the webkit-reviews mailing list