[webkit-reviews] review granted: [Bug 77744] check-webkit-style is throwing an exception : [Attachment 125437] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 3 15:47:43 PST 2012
David Levin <levin at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 77744: check-webkit-style is throwing an exception
https://bugs.webkit.org/show_bug.cgi?id=77744
Attachment 125437: Patch
https://bugs.webkit.org/attachment.cgi?id=125437&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125437&action=review
> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:313
> directories = itertools.chain.from_iterable(directory_lists)
Would it make sense to make itertools.product return [] in this case, so every
place that uses it just works when "not test_list"?
More information about the webkit-reviews
mailing list