[webkit-reviews] review granted: [Bug 77780] Commit scrolling tree state changes to the scrolling tree : [Attachment 125416] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 3 14:40:29 PST 2012
Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 77780: Commit scrolling tree state changes to the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=77780
Attachment 125416: Patch
https://bugs.webkit.org/attachment.cgi?id=125416&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125416&action=review
> Source/WebCore/page/scrolling/ScrollingTree.cpp:68
> + OwnPtr<ScrollingTreeState> newScrollingTreeState = scrollingTreeState;
> + m_rootNode->update(newScrollingTreeState.get());
I don’t think we need the local variable.
> Source/WebCore/page/scrolling/mac/ScrollingTreeNodeMac.h:42
> + RetainPtr<CALayer> m_scrollLayer;
public data member?
More information about the webkit-reviews
mailing list