[webkit-reviews] review denied: [Bug 77751] [BlackBerry] Upstream BlackBerry WebCoreSupport ClientExtension and GeolocationControllerClientBlackBerry classes : [Attachment 125393] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Jacky Jiang <zkjiang008 at gmail.com>'s
request for review:
Bug 77751: [BlackBerry] Upstream BlackBerry WebCoreSupport ClientExtension and
GeolocationControllerClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77751

Attachment 125393: Patch
https://bugs.webkit.org/attachment.cgi?id=125393&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125393&action=review


This is almost perfect, just needs the early return style.

> Source/WebKit/blackberry/WebCoreSupport/ClientExtension.cpp:39
> +    JSValueRef jsRetVal = JSValueMakeUndefined(ctx);

This code should look better with early return if argumentCount <= 0, which is
webkit style, can you do that?