[webkit-reviews] review denied: [Bug 34714] onclick is not reliable for transformed SVG elements : [Attachment 125353] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 3 14:15:12 PST 2012
Dirk Schulze <krit at webkit.org> has denied Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 34714: onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714
Attachment 125353: Patch
https://bugs.webkit.org/attachment.cgi?id=125353&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
r=me. I don't see a relation to the bugs on the bug report and the detailed
list of the build bot. I assume that the build list is the one we should look
at. And I don't sees a failing SVG test.
To the test: you shouldn't generate the html file on yourself. This gets
generated by a script called Tools/Scripts/make-script-test-wrappers (you have
to call it manually. It is located in Tools/Scripts).
Instead you should create the elements dynamically in your script. Would be
great if you can change the test. Please see also at
LayoutTests/svg/dynamic-updates/ for examples.
More information about the webkit-reviews
mailing list