[webkit-reviews] review denied: [Bug 77674] Move attribute storage from NamedNodeMap to ElementAttributeData : [Attachment 125316] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 13:48:15 PST 2012


Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org> has denied Caio Marcelo de
Oliveira Filho <cmarcelo at webkit.org>'s request for review:
Bug 77674: Move attribute storage from NamedNodeMap to ElementAttributeData
https://bugs.webkit.org/show_bug.cgi?id=77674

Attachment 125316: Patch
https://bugs.webkit.org/attachment.cgi?id=125316&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>
After talking with rniwa and kling on IRC, we concluded this patch is too big.

So the plan is to first remove the noise from it by making many of the clients
of NamedNodeMap to interact with Element itself. IOW, expose a way to get
Attribute* from Element. Then this patch for moving attribute storage will be
smaller.


More information about the webkit-reviews mailing list