[webkit-reviews] review granted: [Bug 77767] Update the tree state after layout and add a way to commit it : [Attachment 125391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 13:20:41 PST 2012


Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 77767: Update the tree state after layout and add a way to commit it
https://bugs.webkit.org/show_bug.cgi?id=77767

Attachment 125391: Patch
https://bugs.webkit.org/attachment.cgi?id=125391&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125391&action=review


r=me with some fixes..

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

OOPS!!!

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:202
> +    printf("committing!\n");

:)

> Source/WebCore/page/scrolling/ScrollingTreeState.h:67
> +    // Copies the current tree state and clears the changed properties mask
in the original

Missing period at end of sentence


More information about the webkit-reviews mailing list