[webkit-reviews] review granted: [Bug 77757] configure: Two tests are displayed on the same line : [Attachment 125373] configure: Print out the -Wno-c++0x-compat test result

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 12:53:06 PST 2012


Martin Robinson <mrobinson at webkit.org> has granted Kalev Lember
<kalevlember at gmail.com>'s request for review:
Bug 77757: configure: Two tests are displayed on the same line
https://bugs.webkit.org/show_bug.cgi?id=77757

Attachment 125373: configure: Print out the -Wno-c++0x-compat test result
https://bugs.webkit.org/attachment.cgi?id=125373&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125373&action=review


> configure.ac:121
> -CXXFLAGS="$TMPCXXFLAGS", CXXFLAGS="$TMPCXXFLAGS -Wno-c++0x-compat")
> +disable_cxx0x_compat=no,
> +disable_cxx0x_compat=yes)
> +AC_MSG_RESULT($disable_cxx0x_compat)
> +if test "$disable_cxx0x_compat" = yes; then
> +  CXXFLAGS="$TMPCXXFLAGS -Wno-c++0x-compat"
> +else
> +  CXXFLAGS="$TMPCXXFLAGS"
> +fi

Would it be sufficient here to simply add AC_MSG_RESULT


More information about the webkit-reviews mailing list