[webkit-reviews] review granted: [Bug 55368] Fix alignment warnings in ARMv7 : [Attachment 122580] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 12:39:37 PST 2012


Filip Pizlo <fpizlo at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 55368: Fix alignment warnings in ARMv7
https://bugs.webkit.org/show_bug.cgi?id=55368

Attachment 122580: Patch
https://bugs.webkit.org/attachment.cgi?id=122580&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122580&action=review


> Source/JavaScriptCore/heap/HandleTypes.h:38
> +    static ExternalType getFromSlot(HandleSlot slot) { return (slot &&
*slot) ? reinterpret_cast<ExternalType>(static_cast<void*>(slot->asCell())) :
0; }

What, exactly, are you getting by putting in this static_cast?


More information about the webkit-reviews mailing list