[webkit-reviews] review denied: [Bug 77685] Ref Tests should support plain SVG files : [Attachment 125301] fixes the bug

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 77685: Ref Tests should support plain SVG files
https://bugs.webkit.org/show_bug.cgi?id=77685

Attachment 125301: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=125301&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125301&action=review


> Tools/Scripts/webkitpy/layout_tests/port/base.py:472
> +	       for (expectation, prefix) in [('==', ''), ('!=', '-mismatch')]:

Nit: Remove unnecessary () and use () instead of []:
  for expectation, prefix in (('==', ''), ('!=', '-mismatch')):

> Tools/Scripts/webkitpy/layout_tests/port/base.py:482
> +	   return any(self.reference_files(test_name))

Do you need any() here?  Don't you just want to see if the return value is not
empty?