[webkit-reviews] review granted: [Bug 77514] ShadowRoot's nodeType should be DOCUMENT_FRAGMENT_NODE. : [Attachment 125307] cleanup. remove unnecessary (hopefully) isShadowRoot() check logic as long as regressions does not happen.

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 77514: ShadowRoot's nodeType should be DOCUMENT_FRAGMENT_NODE.
https://bugs.webkit.org/show_bug.cgi?id=77514

Attachment 125307: cleanup. remove unnecessary (hopefully) isShadowRoot() check
logic as long as regressions does not happen.
https://bugs.webkit.org/attachment.cgi?id=125307&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125307&action=review


Ok. But why is the mac EWS sad? Can you fix before landing?

> Source/WebCore/bindings/js/JSNodeCustom.cpp:259
> +	       // Once we have such APIs, we should call
toV8(static_cast<ShadowRoot*>..).

not sure why you're mentioning V8 in JSC bindings. Typo or mystery? :)