[webkit-reviews] review denied: [Bug 34714] onclick is not reliable for transformed SVG elements : [Attachment 125349] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 34714: onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714

Attachment 125349: Patch
https://bugs.webkit.org/attachment.cgi?id=125349&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125349&action=review


r- because of style.

> Source/WebCore/ChangeLog:8
> +	Use FloatPoints in RenderSVGRoot::nodeAtPoint() when converting the
incoming point to local coordinates.

No tabs at all please.

> LayoutTests/ChangeLog:8
> +	Checks that elementFromPoint() works correctly with SVG elements
defined within a 1x1 viewbox.

Ditto.

> LayoutTests/svg/hittest/script-tests/svg-floating-point-transform.js:6
> +	   {x:1, y:1},
> +	   {x:1, y:399},
> +	   {x:399, y:1},

Indentation should be 4 spaces. For tests as well. Also make a space between
':' and the following number.