[webkit-reviews] review granted: [Bug 77619] Web Inspector: Introduce "Copy XPath" popup menu item for DOM elements : [Attachment 125333] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 77619: Web Inspector: Introduce "Copy XPath" popup menu item for DOM
elements
https://bugs.webkit.org/show_bug.cgi?id=77619

Attachment 125333: Patch
https://bugs.webkit.org/attachment.cgi?id=125333&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125333&action=review


> Source/WebCore/inspector/front-end/DOMAgent.js:300
> +    copyXPath: function(optimized)

Please add @param annotation for optimized.

> Source/WebCore/inspector/front-end/DOMAgent.js:520
> +    xPath: function(optimized)

ditto

> Source/WebCore/inspector/front-end/DOMAgent.js:544
> +    _xPathValue: function(optimized)

ditto