[webkit-reviews] review denied: [Bug 77444] Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher : [Attachment 124984] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 77444: Web Inspector: CodeGeneratorInspector.py: switch domain agents to
formal interfaces in BackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=77444

Attachment 124984: Patch
https://bugs.webkit.org/attachment.cgi?id=124984&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124984&action=review


Looks good, but please add virtual to the methods that became virtual.

> Source/WebCore/inspector/InspectorCSSAgent.h:80
> +    void getMatchedStylesForNode(ErrorString*, int nodeId, const
RefPtr<InspectorArray>* forcedPseudoClasses, const bool* includePseudo, const
bool* includeInherited, RefPtr<InspectorArray>& matchedCSSRules,
RefPtr<InspectorArray>& pseudoIdRules, RefPtr<InspectorArray>&
inheritedEntries);

We usually keep virtual keywords for overridden virtual methods even though C++
doesn't require this.